share logic for getting the in-use MachineConfigs #1783
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tremes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking can you please review and help me with some reviewers and approvers suggestion for this new package? |
| ) | ||
|
|
||
| // GetInUseMachineConfigs filters in-use MachineConfig resources and returns set of their names. | ||
| func GetInUseMachineConfigs(ctx context.Context, clientConfig *rest.Config, poolFilter string) (sets.Set[string], error) { |
There was a problem hiding this comment.
Optionally I can pass the client instances (instead of the config). I think it would allow for some testing.
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tremes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is moving the logic from the https://github.com/openshift/oc/blob/master/pkg/cli/admin/prune/renderedmachineconfigs/renderedmachineconfigs.go#L397 so that it can be reused in the Insights Operator.